fix(build): mark nodejs-whisper external in MCP bundling#44
Merged
Conversation
devglide setup runs scripts/build-mcp.mjs, which bundled the voice MCP with esbuild. nodejs-whisper (an optional whisper.cpp STT dependency) was not in the external allowlist, so esbuild tried to inline it. When the package is absent or fails to install, the build failed with 'Could not resolve nodejs-whisper' and aborted every remaining bundle, degrading all servers to the tsx fallback. The voice provider already imports nodejs-whisper lazily and degrades gracefully at runtime, so it should be external like better-sqlite3 and node-pty rather than bundled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devglide setup runs scripts/build-mcp.mjs, which bundled the voice MCP with esbuild. nodejs-whisper (an optional whisper.cpp STT dependency) was not in the external allowlist, so esbuild tried to inline it. When the package is absent or fails to install, the build failed with 'Could not resolve nodejs-whisper' and aborted every remaining bundle, degrading all servers to the tsx fallback.
The voice provider already imports nodejs-whisper lazily and degrades gracefully at runtime, so it should be external like better-sqlite3 and node-pty rather than bundled.